fix(Select): merge HvOption events (#4483)

lumada-design · Dec 10, 2024 · 4fb3d16 · 4fb3d16
1 parent 4c5c91a
commit 4fb3d16
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/packages/core/src/Select/Option.tsx b/packages/core/src/Select/Option.tsx
@@ -66,8 +66,7 @@ export const HvOption = fixedForwardRef(function HvOption<
       className={cx(classes.root, className, {
         [classes.highlighted]: highlighted,
       })}
-      {...getRootProps()}
-      {...others}
+      {...getRootProps(others)}
     >
       {children}
     </HvListItem>

diff --git a/packages/core/src/Select/Select.test.tsx b/packages/core/src/Select/Select.test.tsx
@@ -69,8 +69,12 @@ describe("Select", () => {
           <HvOption value="opt3">Option3</HvOption>
         </HvOptionGroup>
         <HvOptionGroup label="Group2">
-          <HvOption value="opt4">Option4</HvOption>
-          <HvOption value="opt5">Option5</HvOption>
+          <HvOption value="opt4" onClick={() => {}}>
+            Option4
+          </HvOption>
+          <HvOption value="opt5" onClick={() => {}}>
+            Option5
+          </HvOption>
         </HvOptionGroup>
       </HvSelect>,
     );