Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(FileUploader): add classes, label, accept props #4485

Merged
merged 2 commits into from
Dec 16, 2024
Merged

feat(FileUploader): add classes, label, accept props #4485

merged 2 commits into from
Dec 16, 2024

Conversation

zettca
Copy link
Member

@zettca zettca commented Dec 11, 2024 •
edited
Loading

  • align label with other form elements
  • align acceptedFiles with the native accept attribute
  • add missing classes and fileUploaderClasses
  • refactor DropZone styles & classes
  • add docs, using new label & accept props

@zettca zettca requested a review from a team as a code owner December 11, 2024 15:09
@zettca zettca requested review from plagoa and francisco-guilherme and removed request for a team December 11, 2024 15:09
@github-actions github-actions bot temporarily deployed to uikit/pr-4485 December 11, 2024 15:15 Destroyed
@github-actions github-actions bot temporarily deployed to uikit-docs/pr-4485 December 11, 2024 15:15 Destroyed
@zettca
feat(FileUploader): add classes, label, accept props
6576288 
use native accept attribute
refactor DropZone styles & classes
@github-actions github-actions bot temporarily deployed to uikit/pr-4485 December 12, 2024 10:31 Destroyed
@github-actions github-actions bot temporarily deployed to uikit-docs/pr-4485 December 12, 2024 10:31 Destroyed
@github-actions github-actions bot temporarily deployed to uikit/pr-4485 December 12, 2024 10:47 Destroyed
@zettca zettca merged commit ee485de into master Dec 16, 2024
12 checks passed
@zettca zettca deleted the fix/fileuploader branch December 16, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plagoa plagoa plagoa approved these changes

@francisco-guilherme francisco-guilherme Awaiting requested review from francisco-guilherme francisco-guilherme is a code owner automatically assigned from lumada-design/imperial

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zettca @plagoa