Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add EmptyState documentation #4488

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

docs: add EmptyState documentation #4488

wants to merge 1 commit into from

Conversation

plagoa
Copy link
Contributor

@plagoa plagoa commented Dec 16, 2024

No description provided.


### Action links

You can specify any React component as the action link. This can be a button, a link, or any other component that you want to use to guide the user to the next step.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
You can specify any React component as the action link. This can be a button, a link, or any other component that you want to use to guide the user to the next step.
You can specify any content as the `message` or `action`. This can be a button, a link, or any other component that you want to use to guide the user to the next step.

React Element: <MyComponent />
React Component: MyComponent
React Node: <MyComponent />, "myString", etc.

action={
<div className="flex flex-col gap-1 items-center">
<HvButton variant="secondarySubtle">Upload data</HvButton>
<HvLink route="/">Back to homepage</HvLink>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HvLink should definetly be deprecated; but we can review this later

action={
<div className="flex flex-col gap-1 items-center">
<HvButton variant="secondarySubtle">Upload data</HvButton>
<HvLink route="/">Back to homepage</HvLink>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, can we improve this now? using href="#" is also better, as clicking the link won't navigate away from from the docs

Suggested change
<HvLink route="/">Back to homepage</HvLink>
<HvTypography link component="a" href="#">Back to homepage</HvTypography>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants