-
-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
start making SPI configurable #807
Conversation
(add spi pins, remove wrong RF24 in there which was not correct even before)
This PR basically ready for review by you @lumapu . It switches to the cutsom SPIClass constructor while keeping backward compatibility, which should be tested by people who own a classic ESP32 and ESP8266. Also, the available pinlist for esp32s3 has been added, as it has more pins and more flexibility even compared to the ESP32. |
looks really good to me, thank you for your contribution! |
I should note that it is probably necessary to do a complete config erase for this build as it alters the configuration structure, I at least noticed some weird config display (actually it is logical as we expanded the pinout section, so the old config layout won't match) |
This is work in progress to make SPI pins configurable as the old hardcoded approach breaks down as described in #806