Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples droplet fusion #674

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Examples droplet fusion #674

merged 1 commit into from
Sep 5, 2024

Conversation

aafkevandenberg
Copy link
Collaborator

@aafkevandenberg aafkevandenberg commented Jul 18, 2024

An example of how to analyze a droplet fusion event

Build can be found here: https://lumicks-pylake.readthedocs.io/en/examples_droplet_fusion/examples/droplet_fusion/droplet_fusion.html

Copy link
Member

@JoepVanlier JoepVanlier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a quick first pass and made a few notes on things I noticed.

docs/examples/droplet_fusion/droplet_fusion.rst Outdated Show resolved Hide resolved
docs/examples/droplet_fusion/droplet_fusion.rst Outdated Show resolved Hide resolved
docs/examples/droplet_fusion/droplet_fusion.rst Outdated Show resolved Hide resolved
docs/examples/droplet_fusion/droplet_fusion.rst Outdated Show resolved Hide resolved
docs/examples/droplet_fusion/droplet_fusion.rst Outdated Show resolved Hide resolved
docs/examples/droplet_fusion/droplet_fusion.rst Outdated Show resolved Hide resolved
docs/examples/droplet_fusion/droplet_fusion.rst Outdated Show resolved Hide resolved
docs/examples/droplet_fusion/droplet_fusion.rst Outdated Show resolved Hide resolved
docs/examples/droplet_fusion/droplet_fusion.rst Outdated Show resolved Hide resolved
@aafkevandenberg aafkevandenberg force-pushed the examples_droplet_fusion branch 3 times, most recently from 28d1954 to 3cf1351 Compare July 26, 2024 11:09
@aafkevandenberg aafkevandenberg force-pushed the examples_droplet_fusion branch 2 times, most recently from a1ba41c to eddcefb Compare August 21, 2024 07:43
@aafkevandenberg aafkevandenberg marked this pull request as ready for review August 21, 2024 10:10
@aafkevandenberg aafkevandenberg requested review from a team as code owners August 21, 2024 10:10
Copy link
Member

@JoepVanlier JoepVanlier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! I only have a last few tiny requests.

docs/examples/droplet_fusion/droplet_fusion.rst Outdated Show resolved Hide resolved
docs/examples/droplet_fusion/droplet_fusion.rst Outdated Show resolved Hide resolved
@@ -20,4 +20,6 @@ For all of the examples, it is assumed that the following lines precede any othe
twlc_fitting/twlc_fitting
reca_fitting/reca_fitting
cas9_kymotracking/cas9_kymotracking
hairpin_fitting/hairping_unfolding
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is on main. Rebasing to main would fix this, rather than adding it on this PR. This will only result in a merge conflict. :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to drop this line. Docs won't build with a dead link.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the hairpin example was already merged into this branch. The doc build failed because I had 2 lines in the index file referring to the hairpin notebook, one of which had a spelling error.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that is what I meant.

Copy link
Member

@JoepVanlier JoepVanlier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. A few small suggestions. Don't forget to remove the old link, because the docs won't build if you keep it around (see comments).

@@ -20,4 +20,6 @@ For all of the examples, it is assumed that the following lines precede any othe
twlc_fitting/twlc_fitting
reca_fitting/reca_fitting
cas9_kymotracking/cas9_kymotracking
hairpin_fitting/hairping_unfolding
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to drop this line. Docs won't build with a dead link.

docs/examples/droplet_fusion/droplet_fusion.rst Outdated Show resolved Hide resolved
docs/examples/droplet_fusion/droplet_fusion.rst Outdated Show resolved Hide resolved
docs/examples/droplet_fusion/droplet_fusion.rst Outdated Show resolved Hide resolved
Copy link
Member

@JoepVanlier JoepVanlier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small last changes. One thing that's curious is that the code seems to generate a different y-label for a figure than the figure you uploaded.

docs/examples/droplet_fusion/droplet_fusion.rst Outdated Show resolved Hide resolved
docs/examples/droplet_fusion/droplet_fusion.rst Outdated Show resolved Hide resolved
docs/examples/droplet_fusion/droplet_fusion.rst Outdated Show resolved Hide resolved
docs/examples/droplet_fusion/droplet_fusion.rst Outdated Show resolved Hide resolved
docs/examples/droplet_fusion/droplet_fusion.rst Outdated Show resolved Hide resolved
docs/examples/droplet_fusion/droplet_fusion.rst Outdated Show resolved Hide resolved
docs/examples/droplet_fusion/droplet_fusion.rst Outdated Show resolved Hide resolved
docs/examples/droplet_fusion/droplet_fusion.rst Outdated Show resolved Hide resolved
docs/examples/droplet_fusion/droplet_fusion.rst Outdated Show resolved Hide resolved
docs/examples/droplet_fusion/droplet_fusion.rst Outdated Show resolved Hide resolved
@aafkevandenberg aafkevandenberg force-pushed the examples_droplet_fusion branch 4 times, most recently from 8c830fd to 08565d4 Compare September 5, 2024 13:21
Copy link
Member

@JoepVanlier JoepVanlier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! :shipit:

@aafkevandenberg aafkevandenberg merged commit cde5cc4 into main Sep 5, 2024
8 checks passed
@aafkevandenberg aafkevandenberg deleted the examples_droplet_fusion branch September 5, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants