fix: AWS SdkV2 support with auto-trace #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #78 +/- ##
============================================
- Coverage 78.37% 76.54% -1.84%
Complexity 436 436
============================================
Files 49 50 +1
Lines 2021 2072 +51
Branches 214 217 +3
============================================
+ Hits 1584 1586 +2
- Misses 357 406 +49
Partials 80 80 ☔ View full report in Codecov by Sentry. |
nadav3396
commented
Jul 1, 2024
| @@ -89,4 +92,26 @@ public static boolean isKillSwitchOn() { | |||
| String value = System.getenv("LUMIGO_SWITCH_OFF"); | |||
| return "true".equalsIgnoreCase(value); | |||
| } | |||
|
|
|||
| public static boolean isAutoTrace() { | |||
There was a problem hiding this comment.
I want to inject the jar only when we use autoTrace
nadav3396
commented
Jul 1, 2024
| try { | ||
| SdkHttpRequest.Builder requestBuilder = context.httpRequest().toBuilder(); | ||
| requestBuilder.appendHeader("X-Amzn-Trace-Id", spansContainer.getPatchedRoot()); |
There was a problem hiding this comment.
We dont need to inject traceId because its auto injected by aws
GuyMoses
approved these changes
Jul 1, 2024
| @@ -131,7 +131,7 @@ Add the environment variable `JAVA_TOOL_OPTIONS` to your Lambda functions and se | |||
|
|
|||
| ### Supported Instrumentation Libraries | |||
|
|
|||
| - Aws SDK V1 | |||
| - Aws SDK V1 (Supported only from dependency and not from the auto trace with lambda layer) | |||
There was a problem hiding this comment.
can we somehow know it and print it as warn?
I mean, if the sdk1 exist, and we were imported with a layer
Comment on lines
49
to
50
| if (isAutoTrace()) { | ||
| installTracerJar(inst); |
There was a problem hiding this comment.
must this be executed lastly?
because it seems not pure/ not dry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.