Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FileSpanExporter should not close the underpinning file descriptor #167

Closed
mmanciop opened this issue Apr 12, 2023 · 1 comment · Fixed by #172
Closed

FileSpanExporter should not close the underpinning file descriptor #167

mmanciop opened this issue Apr 12, 2023 · 1 comment · Fixed by #172
Assignees
@doriaviram
Labels
bug Something isn't working released

Comments

@mmanciop
Copy link
Contributor

The fact that FileSpanExporter closes the underpinning file descriptor causes issues with dockerized applications when the file it is writing to is /dev/std{out|err}.
@mmanciop mmanciop added the bug Something isn't working label Apr 12, 2023
mmanciop pushed a commit that referenced this issue Apr 28, 2023
fix: reimplement FileSpanExporter to use async APIs and not to close …
a18e45a 
…fd on exit unless it's a regular file

Fixes #167
@mmanciop mmanciop mentioned this issue Apr 28, 2023
Closed
mmanciop pushed a commit that referenced this issue Apr 30, 2023
fix: reimplement FileSpanExporter to use async APIs and not to close …
111bc6c 
…fd on exit unless it's a regular file

Fixes #167
mmanciop pushed a commit that referenced this issue Apr 30, 2023
fix: reimplement FileSpanExporter to use async APIs and not to close …
9be174a 
…fd on exit unless it's a regular file

Fixes #167
@mmanciop mmanciop mentioned this issue May 4, 2023
Merged
mmanciop pushed a commit that referenced this issue May 7, 2023
feat: Node.js 20 support, do not initialize distro in unsupported Nod…
0647749 
…e.js versions and other fixes (#172)

* Do not activate the distro is the Node.js version is not supported (tested on Node.js 10 and 12) #172
* FileSpanExporter should not close the underpinning file descriptor #167
* Add support for Node.js 20
* Update OpenTelemetry baseline to SDK v1.9.0, contrib 0.38.0 (or highest otherwise available)
doriaviram pushed a commit that referenced this issue May 7, 2023
@semantic-release-bot
chore(release): 1.20.0 [skip ci]
6ad24e3 
# [1.20.0](v1.19.1...v1.20.0) (2023-05-07)

### Features

* Node.js 20 support, do not initialize distro in unsupported Node.js versions and other fixes ([#172](#172)) ([0647749](0647749)), closes [#167](#167)
@doriaviram
Copy link
Contributor

🎉 This issue has been resolved in version 1.20.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@doriaviram doriaviram

Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
2 participants
@mmanciop @doriaviram