fix: do not initialize distro in unsupported NodeJS versions #172

mmanciop · 2023-04-28T14:11:18Z

Batch for fixes for multiple issues.

Rework instrumentation test harness to be reliable, much smaller and written in TypeScript
Unify component and integration tests into instrumentation tests
Speed up and parallelize the build process
Do not activate the distro is the Node.js version is not supported Build into startup checks for the Node.js version #169
Rework FileSpanExporter not to close non-regular files FileSpanExporter should not close the underpinning file descriptor #167
Use local HTTP server for integration tests Replace remove web services in integration/component tests with local http server #166
Add support for Node.js 20
Update OpenTelemetry baseline to SDK v1.9.0, contrib 0.38.0 (or highest otherwise available)

Fixes #166
Fixes #167
Fixes #169

…fd on exit unless it's a regular file Fixes #167

[skip ci]

…porter and test code

[skip ci]

mmanciop · 2023-05-05T08:59:21Z

Relevant integration tests pass on CircleCI.

package.json

GuyMoses

looks good!

I'm afraid that changing wrapper -> distro will break IT.
If does break - you'll need to modify IT code

# [1.20.0](v1.19.1...v1.20.0) (2023-05-07) ### Features * Node.js 20 support, do not initialize distro in unsupported Node.js versions and other fixes ([#172](#172)) ([0647749](0647749)), closes [#167](#167)

doriaviram · 2023-05-07T10:25:03Z

🎉 This PR is included in version 1.20.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Michele Mancioppi added 4 commits April 28, 2023 15:41

fix: do not initialize distro on unsupported Node.js versions

ab4ae24

fix: build dependencies

97dbbec

fix: inclusion of supported versions in dedicated json file

8295b68

fix: eval output

d26c6fe

mmanciop force-pushed the RD-10336-unsupported-nodejs branch from 289aff1 to d26c6fe Compare April 28, 2023 14:17

fix: async load of distro init

3d9dd21

mmanciop force-pushed the RD-10336-unsupported-nodejs branch from a59cb3b to 3d9dd21 Compare April 28, 2023 14:32

Michele Mancioppi added 6 commits April 28, 2023 17:21

fix: distro installation in component tests

7e570f3

fix: distro installation in integration tests

4ebff7c

fix: various fixes

763b2b5

fix: spurious logs

ac4afea

chore: remove multiline test dependency

a6e42e8

fix: deprecation warning for Buffer()

3be78e9

This was referenced Apr 30, 2023

fix: avoid double registration startup logs #173

Closed

chore: remove multiline test dependency #170

Closed

fix: reimplement FileSpanExporter to use async APIs #171

Closed

fix: reimplement FileSpanExporter to use async APIs and not to close …

9be174a

…fd on exit unless it's a regular file Fixes #167

mmanciop force-pushed the RD-10336-unsupported-nodejs branch from 111bc6c to 9be174a Compare April 30, 2023 12:55

Michele Mancioppi added 9 commits May 2, 2023 18:41

fix: http testing issues, streamline distro init

4c02bb2

fix: http component tests

e4905be

fix: increase delay for http test

fbe11d1

fix: test setup

3c1704a

fix: increase http timeout some more

7ddef22

chore: debug output for HTTP tests

f32bbaf

fix: adjust component test assertions and document flakiness

4ffbcc5

fix: http component tests

657af60

fix: lint and increase parallelization in build

625ab3e

mmanciop force-pushed the RD-10336-unsupported-nodejs branch from 4b73805 to 625ab3e Compare May 3, 2023 12:54

Michele Mancioppi added 2 commits May 3, 2023 15:01

fix: delete spurious file

66a2fa0

[skip ci]

fix: lint job in ci

c620149

Michele Mancioppi added 3 commits May 4, 2023 11:41

fix: remove no-longer existing job

fd3d2a1

fix: express tests

90632e6

chore: improve build job names

8b554f9

[skip ci]

mmanciop force-pushed the RD-10336-unsupported-nodejs branch from 6b5c166 to 8b554f9 Compare May 4, 2023 10:24

Michele Mancioppi added 13 commits May 4, 2023 13:03

chore: parallelize instrumentation tests

0cb9d29

fix: build?

007deb0

fix: improve build parallelization

a790589

chore: add debug output to troubleshoot express flakiness

79c2391

chore: more debug info for flaky express tests

19cee95

fix: remove unnecessary dependency

bc42640

chore: TS-ify express tests

4982cb6

fix: adjust express.js instrumentation expectations

e7a7611

fix: remove unused upstream package

61301b2

fix: workaround for Express.js tests flakiness

749d214

fix: resilience in readSpanDump for race-condition between FileSpanEx…

1f5d1e6

…porter and test code

fix: workaround for legacy tarball name in integration tests

f49a1ef

chore: remove code duplication and unnecessary dependency in tests

d399cf5

[skip ci]

mmanciop requested a review from GuyMoses May 5, 2023 08:58

mmanciop commented May 5, 2023

View reviewed changes

package.json Show resolved Hide resolved

mmanciop commented May 5, 2023

View reviewed changes

package.json Show resolved Hide resolved

mmanciop commented May 5, 2023

View reviewed changes

package.json Show resolved Hide resolved

doriaviram approved these changes May 5, 2023

View reviewed changes

mmanciop mentioned this pull request May 6, 2023

feat: implement finer granularity to LUMIGO_SECRET_MASKING_REGEX #164

Merged

GuyMoses approved these changes May 7, 2023

View reviewed changes

mmanciop merged commit 0647749 into main May 7, 2023

mmanciop deleted the RD-10336-unsupported-nodejs branch May 7, 2023 10:23

doriaviram added the released label May 7, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: do not initialize distro in unsupported NodeJS versions #172

fix: do not initialize distro in unsupported NodeJS versions #172

mmanciop commented Apr 28, 2023 •

edited

Loading

mmanciop commented May 5, 2023

GuyMoses left a comment

doriaviram commented May 7, 2023

fix: do not initialize distro in unsupported NodeJS versions #172

fix: do not initialize distro in unsupported NodeJS versions #172

Conversation

mmanciop commented Apr 28, 2023 • edited Loading

mmanciop commented May 5, 2023

GuyMoses left a comment

Choose a reason for hiding this comment

doriaviram commented May 7, 2023

mmanciop commented Apr 28, 2023 •

edited

Loading