feat: allow disabling postgres, nestjs automatic instrumentation through env-var #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }); | ||
|
|
||
| let lumigoPgInstrumentation = new LumigoPgInstrumentation(); | ||
|
|
||
| test('disable pg instrumentation', () => { |
There was a problem hiding this comment.
I'd go further and replace this with an actual instrumentation test, that sets the env-var to false and makes sure no spans were produced - see an example of something similar I've done with the aws-sdk V3 .
harelmo-lumigo
approved these changes
May 1, 2024
…ation-on-js-distro
…ation-on-js-distro
GuyMoses
changed the title
harelmo-lumigo
approved these changes
May 15, 2024
GuyMoses
deleted the
RD-12662-allow-disabling-postgres-instrumentation-on-js-distro
branch
lumigo-circleci-github-user
pushed a commit
that referenced
this pull request
May 16, 2024
# [1.41.0](v1.40.1...v1.41.0) (2024-05-16) ### Features * allow disabling postgres, nestjs automatic instrumentation through env-var ([#355](#355)) ([b4d505f](b4d505f))
|
🎉 This PR is included in version 1.41.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.