Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BRD-1348] Use url encoded branch name for gitlab #76

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

[BRD-1348] Use url encoded branch name for gitlab #76

wants to merge 14 commits into from

Conversation

valikos
Copy link

@valikos valikos commented Dec 7, 2020 •
edited
Loading

https://docs.gitlab.com/ce/api/README.html#namespaced-path-encoding

Gitlab::Error::NotFound: Server responded with code 404, message: 404 Not Found. Request URI: https://gitlab.com/api/v4/projects/---abs%2Fm---e%2FL---d/repository/commits/valikos/test-txgh-1

@valikos valikos changed the title [BRD-1348] Use url encode branch name for gitlab [BRD-1348] Use url encoded branch name for gitlab Dec 7, 2020
camertron
camertron approved these changes Dec 7, 2020
View reviewed changes
Copy link

@camertron camertron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool 😎

@valikos valikos added the WIP Work in progress label Dec 7, 2020
@valikos valikos requested a review from kastner December 14, 2020 19:37
@valikos valikos force-pushed the feature/BRD-1348-gitlab-updater branch from 9b86fd0 to 3f36cfb Compare January 11, 2021 19:38
@valikos valikos removed the WIP Work in progress label Jan 13, 2021
@valikos
Copy link
Author

valikos commented Jan 13, 2021

Finally.
I found all the problem things.
Checked integration locally.
Everything works fine.

Groovej
Groovej reviewed Jan 15, 2021
View reviewed changes
Copy link

@Groovej Groovej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. 💪

andriimosin
andriimosin approved these changes Jan 27, 2021
View reviewed changes
Copy link

@andriimosin andriimosin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dude, yes! Great job! It is already approved by @camertron (hey buddy) and this is making me feel good about it 🙌

kastner
kastner approved these changes Mar 10, 2021
View reviewed changes
Copy link

@kastner kastner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Groovej Groovej Groovej approved these changes

@andriimosin andriimosin andriimosin approved these changes

@camertron camertron camertron approved these changes

@kastner kastner kastner approved these changes

@labrat-viktor labrat-viktor Awaiting requested review from labrat-viktor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@valikos @kastner @camertron @andriimosin @Groovej