This repository has been archived by the owner on Aug 9, 2023. It is now read-only.
Log duration on scrape failures #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we only log the duration of successful data collections but not on failures. This makes it hard to understand the nature of eg. context deadline exceeded. This change moves the duration tracking up to make it availble for error logs giving better insights into how long it took.
kaspernissen
approved these changes
Oct 29, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we only log the duration of successful data collections but not on
failures. This makes it hard to understand the nature of eg. context deadline
exceeded.
This change moves the duration tracking up to make it availble for error logs
giving better insights into how long it took.