Fixes import_into using the previous environment's __newindex if set #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dates to the original commit: cf61a8b |
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Feb 13, 2022
## 1.12.0 (2022-Jan-10) - deprecate: module `pl.text` the contents have moved to `pl.stringx` (removal later) [#407](lunarmodules/Penlight#407) - deprecate: module `pl.xml`, please switch to a more specialized library (removal later) [#409](lunarmodules/Penlight#409) - feat: `utils.npairs` added. An iterator with a range that honours the `n` field [#387](lunarmodules/Penlight#387) - fix: `xml.maptags` would hang if it encountered text-nodes [#396](lunarmodules/Penlight#396) - fix: `text.dedent` didn't handle declining indents nor empty lines [#402](lunarmodules/Penlight#402) - fix: `dir.getfiles`, `dir.getdirectories`, and `dir.getallfiles` now have the directory optional, as was already documented [#405](lunarmodules/Penlight#405) - feat: `array2d.default_range` now also takes a spreadsheet range, which means also other functions now take a range. [#404](lunarmodules/Penlight#404) - fix: `lapp` enums allow [patterns magic characters](https://www.lua.org/pil/20.2.html) [#393](lunarmodules/Penlight#393) - fix: `text.wrap` and `text.fill` numerous fixes for handling whitespace, accented characters, honouring width, etc. [#400](lunarmodules/Penlight#400) - feat: `text.wrap` and `text.fill` have a new parameter to forcefully break words longer than the width given. [#400](lunarmodules/Penlight#400) - fix: `stringx.expandtabs` could error out on Lua 5.3+ [#406](lunarmodules/Penlight#406) - fix: `pl` the module would not properly forward the `newindex` metamethod on the global table. [#395](lunarmodules/Penlight#395) - feat: `utils.enum` added to create enums and prevent magic strings [#408](lunarmodules/Penlight#408) - change: `xml.new` added some sanity checks on input [#397](lunarmodules/Penlight#397) - added: `xml.xml_escape` and `xml.xml_unescape` functions (previously private) [#397](lunarmodules/Penlight#397) - feat: `xml.tostring` now also takes numeric indents (previously only strings) [#397](lunarmodules/Penlight#397) - fix: `xml.walk` now detects recursion (errors out) [#397](lunarmodules/Penlight#397) - fix: `xml.clone` now detects recursion (errors out) [#397](lunarmodules/Penlight#397) - fix: `xml.compare` now detects recursion (errors out) [#397](lunarmodules/Penlight#397) - fix: `xml.compare` text compares now work [#397](lunarmodules/Penlight#397) - fix: `xml.compare` attribute order compares now only compare if both inputs provide an order [#397](lunarmodules/Penlight#397) - fix: `xml.compare` child comparisons failing now report proper error [#397](lunarmodules/Penlight#397)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems like a typo; gmt.__index is always overridden below, so this currently would do nothing, and we wouldn't want to use another table's __newindex as this table's __index.
gmt does sometimes have its own __newindex set below, but AFAICT the case where it's set is mutually exclusive with this case. (__newindex is only set if mod is truthy; mod is truthy if env is originally true, in which case it is set to an empty table; prevenvmt is env's metatable, so not set in that case.)