fix(pretty) error in pl.pretty table sort function #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alerque
requested changes
Jun 9, 2022
alerque
requested changes
Jun 18, 2022
|
@alerque changelog updated. Thank you. |
Function defined when sorting table is not deteministic and makes luajit crash with error: prefix/share/lua/5.1/pl/pretty.lua:286: invalid order function for sorting This patch will fix the problem.
Tieske
changed the title
bungle
added a commit
to Kong/kong
that referenced
this pull request
Aug 8, 2022
### Summary #### 1.13.1 (2022-Jul-22) - fix: `warn` unquoted argument [#439](lunarmodules/Penlight#439) #### 1.13.0 (2022-Jul-22) - fix: `xml.parse` returned nonsense when given a file name [#431](lunarmodules/Penlight#431) - feat: `app.require_here` now follows symlink'd main modules to their directory [#423](lunarmodules/Penlight#423) - fix: `pretty.write` invalid order function for sorting [#430](lunarmodules/Penlight#430) - fix: `compat.warn` raised write guard warning in OpenResty [#414](lunarmodules/Penlight#414) - feat: `utils.enum` now accepts hash tables, to enable better error handling [#413](lunarmodules/Penlight#413) - feat: `utils.kpairs` new iterator over all non-integer keys [#413](lunarmodules/Penlight#413) - fix: `warn` use rawget to not trigger strict-checkers [#437](lunarmodules/Penlight#437) - fix: `lapp` provides the file name when using the default argument [#427](lunarmodules/Penlight#427) - fix: `lapp` positional arguments now allow digits after the first character [#428](lunarmodules/Penlight#428) - fix: `path.isdir` windows root directories (including drive letter) were not considered valid [#436](lunarmodules/Penlight#436)
bungle
added a commit
to Kong/kong
that referenced
this pull request
Aug 8, 2022
### Summary #### 1.13.1 (2022-Jul-22) - fix: `warn` unquoted argument [#439](lunarmodules/Penlight#439) #### 1.13.0 (2022-Jul-22) - fix: `xml.parse` returned nonsense when given a file name [#431](lunarmodules/Penlight#431) - feat: `app.require_here` now follows symlink'd main modules to their directory [#423](lunarmodules/Penlight#423) - fix: `pretty.write` invalid order function for sorting [#430](lunarmodules/Penlight#430) - fix: `compat.warn` raised write guard warning in OpenResty [#414](lunarmodules/Penlight#414) - feat: `utils.enum` now accepts hash tables, to enable better error handling [#413](lunarmodules/Penlight#413) - feat: `utils.kpairs` new iterator over all non-integer keys [#413](lunarmodules/Penlight#413) - fix: `warn` use rawget to not trigger strict-checkers [#437](lunarmodules/Penlight#437) - fix: `lapp` provides the file name when using the default argument [#427](lunarmodules/Penlight#427) - fix: `lapp` positional arguments now allow digits after the first character [#428](lunarmodules/Penlight#428) - fix: `path.isdir` windows root directories (including drive letter) were not considered valid [#436](lunarmodules/Penlight#436)
StarlightIbuki
pushed a commit
to Kong/kong
that referenced
this pull request
Aug 9, 2022
### Summary #### 1.13.1 (2022-Jul-22) - fix: `warn` unquoted argument [#439](lunarmodules/Penlight#439) #### 1.13.0 (2022-Jul-22) - fix: `xml.parse` returned nonsense when given a file name [#431](lunarmodules/Penlight#431) - feat: `app.require_here` now follows symlink'd main modules to their directory [#423](lunarmodules/Penlight#423) - fix: `pretty.write` invalid order function for sorting [#430](lunarmodules/Penlight#430) - fix: `compat.warn` raised write guard warning in OpenResty [#414](lunarmodules/Penlight#414) - feat: `utils.enum` now accepts hash tables, to enable better error handling [#413](lunarmodules/Penlight#413) - feat: `utils.kpairs` new iterator over all non-integer keys [#413](lunarmodules/Penlight#413) - fix: `warn` use rawget to not trigger strict-checkers [#437](lunarmodules/Penlight#437) - fix: `lapp` provides the file name when using the default argument [#427](lunarmodules/Penlight#427) - fix: `lapp` positional arguments now allow digits after the first character [#428](lunarmodules/Penlight#428) - fix: `path.isdir` windows root directories (including drive letter) were not considered valid [#436](lunarmodules/Penlight#436)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Function defined when sorting table is not deterministic and makes luajit
crash with error:
prefix/share/lua/5.1/pl/pretty.lua:286: invalid order function for sorting
This patch will fix the problem #429