fix: properly error out on bad config files

busted/modules/cli.lua

@@ -168,17 +168,34 @@ return function(options)
     end
 
     -- Load busted config file if available
-    local bustedConfigFilePath = cliArgs.f or path.normpath(path.join(cliArgs.directory, '.busted'))
-    local bustedConfigFile = loadfile(bustedConfigFilePath)
-    if bustedConfigFile then
-      local ok, config = pcall(function()
-        local conf, err = configLoader(bustedConfigFile(), cliArgsParsed, cliArgs)
-        return conf or error(err, 0)
-      end)
-      if not ok then
-        return nil, appName .. ': error: ' .. config
+    local bustedConfigFilePath
+    if cliArgs.f then
+      -- if the file is given, then we require it to exist
+      if not path.isfile(cliArgs.f) then
+        return nil, ("specified config file '%s' not found"):format(cliArgs.f)
+      end
+      bustedConfigFilePath = cliArgs.f
+    else
+      -- try default file
+      bustedConfigFilePath = path.normpath(path.join(cliArgs.directory, '.busted'))
+      if not path.isfile(bustedConfigFilePath) then
+        bustedConfigFilePath = nil  -- clear default file, since it doesn't exist
+      end
+    end
+    if bustedConfigFilePath then
+      local bustedConfigFile, err = loadfile(bustedConfigFilePath)
+      if not bustedConfigFile then
+        return nil, ("failed loading config file `%s`: %s"):format(bustedConfigFilePath, err)
       else
-        cliArgs = config
+        local ok, config = pcall(function()
+          local conf, err = configLoader(bustedConfigFile(), cliArgsParsed, cliArgs)
+          return conf or error(err, 0)
+        end)
+        if not ok then
+          return nil, appName .. ': error: ' .. config
+        else
+          cliArgs = config
+        end
       end
     else
       cliArgs = tablex.merge(cliArgs, cliArgsParsed, true)

spec/.hidden/.busted_bad

@@ -5,7 +5,7 @@ return {
   default = {
     ['ROOT'] = {'specs'},
     ['pattern'] = '_spec%.lua$',
-    ['loaders'] = doesnotexist.loaders,
+    ['loaders'] = doesnotexist.loaders, -- errors when run
     ['verbose'] = true,
   },
   test = {

spec/.hidden/.busted_bad_syntax

@@ -0,0 +1,14 @@
+return {
+  _all = {
+    ['ROOT'] = {'tests'},
+  },
+  default = {
+    ['ROOT'] = {'specs'},
+    ['pattern'] = '_spec%.lua$',
+    ['loaders'] = doesnotexist.loaders,
+    ['verbose'] = true,
+  },
+  test = {
+    ['pattern'] = '_test%.lua$',
+  }
+-- }  -- missing bracket, errors when compiled

spec/cl_spec.lua

@@ -211,6 +211,24 @@ describe('Tests the busted command-line options', function()
     assert.is_equal(1, errcnt)
   end)
 
+  it('tests running a non-existing configfile', function()
+    local success, errcnt = executeBusted('--config-file=spec/.hidden/.this_one_does_not_exist --pattern=cl_execute_fail.lua$')
+    assert.is_false(success)
+    assert.is_equal(0, errcnt)
+  end)
+
+  it('tests running a non-compiling configfile', function()
+    local success, errcnt = executeBusted('--config-file=spec/.hidden/.busted_bad_syntax --pattern=cl_execute_fail.lua$')
+    assert.is_false(success)
+    assert.is_equal(0, errcnt)
+  end)
+
+  it('tests running a configfile throwing errors when being run', function()
+    local success, errcnt, out, err = executeBusted('--config-file=spec/.hidden/.busted_bad --pattern=cl_execute_fail.lua$')
+    assert.is_false(success)
+    assert.is_equal(0, errcnt)
+  end)
+
   it('tests running with --output specified', function()
     local success, errcnt = executeBusted('--pattern=cl_success.lua$ --output=TAP')
     assert.is_true(success)