Update markup.lua #404
Closed
Update markup.lua #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Making a better one following the indentation of the repo |
|
For future reference next time don't close PRs, just continue making amend commits in the same branch. |
Please excuse me |
|
No worries, you live and learn. Since you already have the other one open (and there is no delete) we'll just close this one and more on with review in the other one. |
|
you:
my bio:
Yeah last time I teached a translator how to rename a pr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed:
/usr/local/share/lua/5.1/ldoc/markup.lua:159: attempt to index local 'line' (a nil value)By adding a check enclosing all the lines that play with
linemaking sure is notnilI Don't know exactly why is being triggered but i hope it helps.