Unbound splat arguments, fixes GH-54 #59
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alerque
force-pushed
the
unbounded-splats
branch
from
7638347
to
a968c90
Compare
BREAKING CHANGE: The default maxcount value for SPLAT arguments is now
unlimited. The previous default was 1. That was unexpected for many
folks and arguably wrong, but fixing it is a major breaking change and
consumers will need to adjust, hence the major version bump. The old
behaviour can be achieved by setting the maxcount to 1 again:
cli:splat('MY_SPLAT', 'Description', nil, 1)
Additionally a limit of 999 has been resolved so unlimited arguments can
be accepted.
alerque
force-pushed
the
unbounded-splats
branch
from
a968c90
to
2da9ecd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, this is a breaking change and requires a major release.
The patch makes it so that we no longer reject more than 999 repetitions
for a splat argument, and that by default we allow for unlimited
arguments (maxcount=0 or nil) instead of 1.