Add default value to Spy constructor argument #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows replacing ```lua mySpy = spy.new(function() end) ``` with ```lua mySpy = spy.new() ```
|
Submitting without tests as I do not know if this change is welcome. If is it, I will happily add some tests to this PR. |
|
Seems reasonable. Add some tests and 👍 |
|
Note that I did not run this test as I do not have lua installed |
|
Would be nice to have some instructions on how to run the tests locally, especially without installing lua. In my project I added some docker stuff that allows me to run That won't work here since it is busted itself, and it is not really clear to me how to make it work. Seems like it gets rather involved with all the stuff in .travis/. |
|
@ajacksified just tested it locally. lgtm. |
|
@ajacksified can we merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows replacing
with