fix(argcount) fix n if too low #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With Luassert, an assertion is responsible for passing the args to 'say'. The args table is often passed along from the internal luassert one to 'say'. If, for some messages, an extra argument is inserted, and the assertion does not increase the existing 'n' field on that table, then 'say' will use 'n' and be one argument short.
alerque
approved these changes
Aug 27, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Luassert, an assertion is responsible for passing the args
to 'say'. The args table is often passed along from the internal
luassert one to 'say'. If, for some messages, an extra argument is
inserted, and the assertion does not increase the existing 'n' field
on that table, then 'say' will use 'n' and be one argument short.
This is an urgent fix, since it broke some CI. Busted doesn't have the say version pinned, so even older versions of Busted will install the recently released version and will break.