Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add checked_total metric to tcp checker #16

Merged
merged 2 commits into from
Feb 12, 2020
Merged

Add checked_total metric to tcp checker #16

merged 2 commits into from
Feb 12, 2020

Conversation

Crevil
Copy link
Contributor

@Crevil Crevil commented Feb 12, 2020

Adds a counter tracking when the tcp-checker runs.
It also fixes a bug in the open_info metric where it was never set to 0 if the
connection was no longer open.

Add checked_total metric to tcp checker
564f843 
Adds a counter tracking when the tcp-checker runs.
It also fixes a bug in the open_info metric where it was never set to 0 if the
connection was no longer open.
@Crevil Crevil requested a review from emilingerslev February 12, 2020 13:04
emilingerslev
emilingerslev suggested changes Feb 12, 2020
View reviewed changes
Copy link
Contributor

@emilingerslev emilingerslev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually my idea was a checked_successfully_total, but I really like this 👍
Would still really like the successful option, so we could add a label to your checked_total like describe in my comments.

internal/metrics/metrics.go Outdated Show resolved Hide resolved
internal/metrics/metrics.go Show resolved Hide resolved
@Crevil Crevil requested a review from emilingerslev February 12, 2020 13:57
emilingerslev
emilingerslev approved these changes Feb 12, 2020
View reviewed changes
Copy link
Contributor

@emilingerslev emilingerslev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful! Thanks 🙏 👍

@Crevil Crevil merged commit 449174e into master Feb 12, 2020
@Crevil Crevil deleted the feature/tcp-checker-checked-metric branch February 12, 2020 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilingerslev emilingerslev emilingerslev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Crevil @emilingerslev