Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Node.js (v6.9.5 -> v8.9.1) #520

Merged
merged 5 commits into from
Nov 14, 2017
Merged

Upgrade Node.js (v6.9.5 -> v8.9.1) #520

merged 5 commits into from
Nov 14, 2017

Conversation

taxookim
Copy link
Contributor

@taxookim taxookim commented Nov 12, 2017 •
edited
Loading

Upgrade Node.js (v6.9.5 -> v8.9.1)

ISSUE=#518

@taxookim taxookim requested a review from romandev as a code owner November 12, 2017 07:22
@nadongguri
Copy link
Collaborator

I left a command. Overall, LGTM.

@romandev
Copy link
Member

@taxookim You should add your name and email to AUTHORS file.
Also, you had to add a blank line between your commit description and ISSUE= as follows.

Blah Blah

ISSUE=#518

romandev
romandev approved these changes Nov 14, 2017
View reviewed changes
Copy link
Member

@romandev romandev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@romandev romandev merged commit aecd7a9 into lunchclass:master Nov 14, 2017
romandev added a commit that referenced this pull request Nov 17, 2017
@romandev
Revert "Upgrade Node.js (v6.9.5 -> v8.9.1) (#520)"
7c73963 
This reverts commit aecd7a9.

Revert reasons:
  The change breaks AppVeyor build.

ISSUE=#518,#531
romandev added a commit that referenced this pull request Nov 17, 2017
@romandev
Revert "Upgrade Node.js (v6.9.5 -> v8.9.1) (#520)" (#532)
4a04bf3 
This reverts commit aecd7a9.

Revert reasons:
  The change breaks AppVeyor build.

ISSUE=#518,#531
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romandev romandev romandev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@taxookim @nadongguri @romandev