Fix compatibility with httpx 0.28.0

[ndhansen]

Prior to httpx version 0.28.0, request methods were implicitly converted from bytes to strings. In version 0.28.0 that is no longer the case.

Since httpx request objects expect strings for the method field, and httpcore request objects enforce bytes, I've copied the conversion from bytes to strings from the previous httpx version in to respx.

I didn't add tests because there are no explicit tests on the to_httpx_request method, but I can if you'd like.

Fixes #277.

[mjpieters]

I note that the new httpx code still uppercases the method, so that's redundant here. I'd just decode from bytes:

Suggested change

	method = (
	request.method.decode("ascii").upper()
	if isinstance(request.method, bytes)
	else request.method.upper()
	)
	method = (
	request.method.decode("ascii")
	if isinstance(request.method, bytes)
	else request.method
	)

[francoisfreitag]

Should a DeprecationWarning be raised for bytes so that codebases can be updated and this support can eventually be dropped?

[mjpieters]

Yes, I'd expect respx to follow the same argument conventions as httpx, and the project shouldn't try and maintain accepting bytes here if httpx has dropped support.

[hugovk]

Should the minimum HTTPX version also be bumped to match?

respx/setup.py

Line 44 in 366dd0b

install_requires=["httpx>=0.21.0"],

[francoisfreitag]

Suggested as ndhansen#1.

[francoisfreitag]

Should the minimum HTTPX version also be bumped to match?

I don’t think so, the library should still be compatible with older versions of httpx (they used to accept bytes for the method kwarg).

[francoisfreitag]

The bytes come from httpcore, and we’re only getting bytes because we’re hooking the mock after httpcore issued the request. So there’s nothing users can do about this warning.

[francoisfreitag]

Commit that changes httpx._model.Request constructor: encode/httpx@6622553