-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing vector methods #228
Add missing vector methods #228
Conversation
Nice, thank you for the PR! Could we expand the
We don't have much in terms of tests for methods there yet but I think this would be a good opportunity to start and shouldn't be too complicated to do. |
Sure thing, I should have time to add to those tests tonight. |
Added to the tests for the methods in this PR, as well as There might be a better way to test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Adds the following methods:
Vector2:
Vector3:
Doesn't implement optional
isSigned
boolean forVector2:Angle(rhs, isSigned)
Not totally sure if Option would be a good fit here. The optional axis vector is also missing onVector3:Angle(rhs, axis)
Closes #214