Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor modal tests #2317

Merged
merged 6 commits into from
Mar 21, 2019
Merged

refactor modal tests #2317

merged 6 commits into from
Mar 21, 2019

Conversation

fedekunze
Copy link
Contributor

@fedekunze fedekunze commented Mar 19, 2019

Description:

Part of #1337

Thank you! 🚀


For contributor:

  • Added entries in PENDING.md with issue # and GitHub username
  • Reviewed Files changed in the github PR explorer
  • Attach screenshots of the UI components on the PR description (if applicable)
  • Scope of work approved for big PRs

For reviewer:

  • Manually tested the changes on the UI

@fedekunze fedekunze changed the title update modal tests refactor modal tests Mar 19, 2019
@fedekunze fedekunze marked this pull request as ready for review March 21, 2019 10:53
@codecov
Copy link

codecov bot commented Mar 21, 2019

Codecov Report

Merging #2317 into develop will decrease coverage by 0.04%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #2317      +/-   ##
===========================================
- Coverage    97.11%   97.07%   -0.05%     
===========================================
  Files          105      105              
  Lines         2326     2325       -1     
  Branches       127      127              
===========================================
- Hits          2259     2257       -2     
  Misses          57       57              
- Partials        10       11       +1
Impacted Files Coverage Δ
.../src/renderer/components/staking/PageValidator.vue 100% <ø> (ø) ⬆️
.../renderer/components/staking/UndelegationModal.vue 100% <ø> (ø) ⬆️
...rc/renderer/components/governance/ModalPropose.vue 100% <100%> (ø) ⬆️
...rc/renderer/components/governance/ModalDeposit.vue 95.65% <0%> (-4.35%) ⬇️

Copy link
Contributor

@sabau sabau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks man

@sabau sabau merged commit c2cefbd into develop Mar 21, 2019
@sabau sabau deleted the fedekunze/1337-refactor-modal-tests branch March 21, 2019 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants