fix rename failed when rewrite public keys (go-gitea#7761)

lunny · Aug 6, 2019 · cc7ba8a · cc7ba8a
1 parent 1b5908f
commit cc7ba8a
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/models/ssh_key.go b/models/ssh_key.go
@@ -642,12 +642,14 @@ func rewriteAllPublicKeys(e Engine) error {
 			}
 			_, err = t.WriteString(line + "\n")
 			if err != nil {
+				f.Close()
 				return err
 			}
 		}
-		defer f.Close()
+		f.Close()
 	}
 
+	t.Close()
 	return os.Rename(tmpPath, fPath)
 }