Remove most calls to com, improve vars.Expand
#22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
reviewed
Mar 21, 2022
modules/markup/html.go
Outdated
| log.Error(err.Error()) | ||
| return | ||
| // here we could just log the error and continue the rendering | ||
| log.Error("unable to expand template vars for ref %s, err:%s", ref.Issue, err.Error()) |
There was a problem hiding this comment.
No, it always has content. See the Expand unit test.
lunny
reviewed
Mar 21, 2022
modules/repository/init.go
Outdated
| @@ -62,7 +62,8 @@ func prepareRepoCommit(ctx context.Context, repo *repo_model.Repository, tmpDir, | |||
| } | |||
| res, err := vars.Expand(string(data), match) | |||
| if err != nil { | |||
| return fmt.Errorf("expand README.md: %v", err) | |||
| // here we could just log the error and continue the rendering | |||
| log.Error("unable to expand template vars for repo README: %s, err: %s", opts.Readme, err.Error()) | |||
There was a problem hiding this comment.
Is that meaningful to write an empty to the file?
There was a problem hiding this comment.
No, it always has content. See the Expand unit test.
lunny
force-pushed
the
lunny/vars_expand
branch
from
3a3b5ee
to
fe2f1ed
Compare
wxiaoguang
force-pushed
the
lunny/vars_expand
branch
2 times, most recently
from
d1d1708
to
73602a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.