Add URL function to serve attachments directly from S3/Minio #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
requested changes
Jun 25, 2020
lunny
reviewed
Jun 25, 2020
|
Please rebase, I just force pushed to this branch |
|
Hopefully that worked... not terribly familiar with the rebase procedure like that. |
|
@tystuyfzand I have merged this PR to my branch. |
GiteaBot
pushed a commit
that referenced
this pull request
Aug 7, 2023
- Currently the post processing will transform all issue indexes (such as `#6`) into a clickable link. - This makes sense in an situation like issues or PRs, where referencing to other issues is quite common and only referencing their issue index is an handy and efficient way to do it. - Currently this is also run for documents (which is the user profile and viewing rendered files), but in those situations it's less common to reference issues by their index and instead could mean something else. - This patch disables this post processing for issue index for documents. Matches Github's behavior. - Added unit tests. - Resolves https://codeberg.org/Codeberg/Community/issues/1120 Co-authored-by: Gusted <postmaster@gusted.xyz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability for S3/Object storage to serve files directly (authenticated, of course) instead of passing through Gitea itself.
This has many benefits, including:
This has a single TODO item, which involves possibly determining whether to inline or attach the file, or serve it as plain text. S3/Minio support the "Content-Disposition" header via the parameter "response-content-disposition" (MinIO Docs, Amazon S3 docs - Overriding Response Header Values), as well as a few others.