-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove shp file format from gis downloads #723
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you confirm the two comments I made ^
@@ -21,7 +21,7 @@ export enum FileType { | |||
@Injectable({providedIn: 'root'}) | |||
export class FileDownloadService { | |||
fileType: FileType = FileType.standard; | |||
format: FileFormat = FileFormat.shp; | |||
format: FileFormat = FileFormat.gpkg; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File download service uses gpkg now that shp was removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, gpkg is the only gis download format now
@@ -439,7 +438,6 @@ | |||
"friend.requests": "Kaveripyynnöt", | |||
"friend.requestSent": "Kaveripyyntö lähetetty", | |||
"gathering.section.outsideSection": "Ei osiota", | |||
"geoConvert.error.too_complex": "Joidenkin havaintojen geometriat ovat liian monimutkaisia .shp-tiedostomuodolle (GeometryCollection). Käytä sen sijaan .gpkg-muotoa tai valitse toinen geometriatyyppi.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you delete references of "too_complex"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had forgotten to delete it, deleted it now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
#711
https://711.dev.laji.fi/observation/list?target=MX.37623
https://711.viranomaiset-dev.laji.fi/usage/my-downloads