Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove shp file format from gis downloads #723

Merged
merged 4 commits into from
Feb 3, 2025

Conversation

@rpulkka rpulkka self-requested a review January 29, 2025 12:07
Copy link
Contributor

@rpulkka rpulkka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you confirm the two comments I made ^

@@ -21,7 +21,7 @@ export enum FileType {
@Injectable({providedIn: 'root'})
export class FileDownloadService {
fileType: FileType = FileType.standard;
format: FileFormat = FileFormat.shp;
format: FileFormat = FileFormat.gpkg;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File download service uses gpkg now that shp was removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, gpkg is the only gis download format now

@@ -439,7 +438,6 @@
"friend.requests": "Kaveripyynnöt",
"friend.requestSent": "Kaveripyyntö lähetetty",
"gathering.section.outsideSection": "Ei osiota",
"geoConvert.error.too_complex": "Joidenkin havaintojen geometriat ovat liian monimutkaisia .shp-tiedostomuodolle (GeometryCollection). Käytä sen sijaan .gpkg-muotoa tai valitse toinen geometriatyyppi.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you delete references of "too_complex"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had forgotten to delete it, deleted it now

@rpulkka rpulkka self-assigned this Jan 29, 2025
Copy link
Contributor

@rpulkka rpulkka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Blodir Blodir added this to the Release 79 milestone Feb 3, 2025
@Blodir Blodir merged commit 46f296e into development Feb 3, 2025
1 check passed
@Blodir Blodir deleted the remove-shp-file-format-711 branch February 3, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants