Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.6.0 #91

Merged
merged 20 commits into from
Mar 8, 2023
Merged

Release 0.6.0 #91

merged 20 commits into from
Mar 8, 2023

Conversation

@luongvo luongvo added this to the 0.6.0 milestone Mar 7, 2023
@luongvo luongvo self-assigned this Mar 7, 2023
@github-actions
Copy link

github-actions bot commented Mar 7, 2023

27 Warnings
⚠️ Big PR
⚠️ Uh oh! AppNavigation.kt is under 95% coverage!
⚠️ Uh oh! AuthRemoteDataSource.kt is under 95% coverage!
⚠️ Uh oh! CompletionScreen.kt is under 95% coverage!
⚠️ Uh oh! ConfirmationDialog.kt is under 95% coverage!
⚠️ Uh oh! DateFormatter.kt is under 95% coverage!
⚠️ Uh oh! HomeScreen.kt is under 95% coverage!
⚠️ Uh oh! Realm.kt is under 95% coverage!
⚠️ Uh oh! SurveyLocalDataSource.kt is under 95% coverage!
⚠️ Uh oh! SurveyRealmObject.kt is under 95% coverage!
⚠️ Uh oh! SurveyRemoteDataSource.kt is under 95% coverage!
⚠️ Uh oh! SurveyScreen.kt is under 95% coverage!
⚠️ Uh oh! UserRemoteDataSource.kt is under 95% coverage!
⚠️ Uh oh! Your project is under 80% coverage!
⚠️ android/src/main/java/vn/luongvo/kmm/survey/android/ui/screens/home/HomeScreen.kt#L78 - The function HomeScreenWithDrawer(appVersion: String, initialDrawerState: DrawerValue, scaffoldState: ScaffoldState, isLoading: Boolean, isRefreshing: Boolean, currentDate: String, user: UserUiModel?, surveys: List, onSurveyClick: (SurveyUiModel?) -> Unit, onRefresh: () -> Unit, onMenuLogoutClick: () -> Unit) has too many parameters. The current threshold is set to 8.
⚠️ android/src/main/java/vn/luongvo/kmm/survey/android/ui/screens/login/LoginScreen.kt#L89 - The function LoginScreenContent is too long (77). The maximum length is 60.
⚠️ android/src/main/res/drawable/bg_login.jpg#L0 - Found bitmap drawable res/drawable/bg_login.jpg in densityless folder
⚠️ android/src/main/res/mipmap-hdpi/ic_launcher_round.png#L0 - Launcher icons should not fill every pixel of their square region; see the design guide for details
⚠️ android/src/main/res/mipmap-ldpi/ic_launcher.png#L0 - Launcher icons should not fill every pixel of their square region; see the design guide for details
⚠️ android/src/main/res/mipmap-mdpi/ic_launcher.png#L0 - Launcher icons should not fill every pixel of their square region; see the design guide for details
⚠️ android/src/main/res/mipmap-mdpi/ic_launcher_round.png#L0 - Launcher icons should not fill every pixel of their square region; see the design guide for details
⚠️ android/src/main/res/mipmap-xxxhdpi/ic_launcher_round.png#L0 - Launcher icon used as round icon did not have a circular shape
⚠️ android/src/staging/res/mipmap-hdpi/ic_launcher_round.png#L0 - Launcher icons should not fill every pixel of their square region; see the design guide for details
⚠️ android/src/staging/res/mipmap-ldpi/ic_launcher.png#L0 - Launcher icons should not fill every pixel of their square region; see the design guide for details
⚠️ android/src/staging/res/mipmap-mdpi/ic_launcher.png#L0 - Launcher icons should not fill every pixel of their square region; see the design guide for details
⚠️ android/src/staging/res/mipmap-mdpi/ic_launcher_round.png#L0 - Launcher icons should not fill every pixel of their square region; see the design guide for details
⚠️ android/src/staging/res/mipmap-xxxhdpi/ic_launcher_round.png#L0 - Launcher icon used as round icon did not have a circular shape

🧛 build Code Coverage: 71.53%

Coverage of Modified Files:

File Coverage
AppColors.kt 99.09%
AppNavigation.kt 0.00%
AuthRemoteDataSource.kt 0.00%
CompletionScreen.kt 0.00%
ConfirmationDialog.kt 64.18%
DateFormatter.kt 0.00%
GetCachedSurveysUseCase.kt 100.00%
GetSurveyDetailUseCase.kt 100.00%
GetSurveysUseCase.kt 100.00%
GetUserProfileUseCase.kt 100.00%
HomeScreen.kt 81.01%
HomeViewModel.kt 100.00%
IsLoggedInUseCase.kt 100.00%
LogInUseCase.kt 100.00%
LogOutUseCase.kt 100.00%
Realm.kt 0.00%
RefreshTokenUseCase.kt 100.00%
SubmitSurveyUseCase.kt 100.00%
Survey.kt 100.00%
SurveyLocalDataSource.kt 0.00%
SurveyRealmObject.kt 84.31%
SurveyRemoteDataSource.kt 0.00%
SurveyRepositoryImpl.kt 100.00%
SurveyScreen.kt 80.68%
TokenLocalDataSource.kt 100.00%
UserRemoteDataSource.kt 0.00%

Modified Files Not Found In Coverage Report:

AuthRepository.kt
Configurations.kt
Dependencies.kt
Fake.kt
Fake.kt
GetCachedSurveysUseCaseTest.kt
GetSurveysUseCaseTest.kt
HomeScreenTest.kt
HomeViewModelTest.kt
LocalModule.kt
LoginScreenTest.kt
SurveyRepository.kt
SurveyRepositoryTest.kt
SurveyScreenTest.kt
UseCaseModule.kt
UserRepository.kt
build.gradle.kts
build.gradle.kts
build.gradle.kts
completion_success.json
project.pbxproj
strings.xml

Codebase cunningly covered by count Shroud 🧛

Generated by 🚫 Danger

@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2023

Codecov Report

Merging #91 (df14cb6) into main (16fa218) will decrease coverage by 0.68%.
The diff coverage is 63.15%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main      #91      +/-   ##
==========================================
- Coverage   67.28%   66.61%   -0.68%     
==========================================
  Files          79       84       +5     
  Lines        1715     1869     +154     
  Branches      322      353      +31     
==========================================
+ Hits         1154     1245      +91     
- Misses        409      458      +49     
- Partials      152      166      +14     
Flag Coverage Δ
unittests 66.61% <63.15%> (-0.68%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../kmm/survey/android/ui/navigation/AppNavigation.kt 0.00% <0.00%> (ø)
.../android/ui/screens/completion/CompletionScreen.kt 0.00% <0.00%> (ø)
...n/luongvo/kmm/survey/android/util/DateFormatter.kt 0.00% <ø> (ø)
...vey/data/local/datasource/SurveyLocalDataSource.kt 0.00% <0.00%> (ø)
...rvey/data/local/datasource/TokenLocalDataSource.kt 100.00% <ø> (ø)
...in/vn/luongvo/kmm/survey/data/local/realm/Realm.kt 0.00% <0.00%> (ø)
...vey/data/remote/datasource/AuthRemoteDataSource.kt 0.00% <ø> (ø)
...y/data/remote/datasource/SurveyRemoteDataSource.kt 0.00% <ø> (ø)
...vey/data/remote/datasource/UserRemoteDataSource.kt 0.00% <ø> (ø)
...mm/survey/domain/usecase/GetSurveyDetailUseCase.kt 100.00% <ø> (ø)
... and 20 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

luongvo added 2 commits March 8, 2023 10:22
…-on-the-home-screen

[#20] [Android] [Integrate] As a user, I can see the app cache and load survey list in Home screen
[#36] Show the confirmation dialog when clicking on Close survey button
Copy link

@suho suho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@luongvo luongvo merged commit ba4d9bd into main Mar 8, 2023
@luongvo luongvo deleted the release/0.6.0 branch March 8, 2023 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants