Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph color config #48

Merged
merged 7 commits into from
Sep 14, 2024
Merged

Graph color config #48

merged 7 commits into from
Sep 14, 2024

Conversation

lusingander
Copy link
Owner

[graph.color]
branches = [
  "#86ac41",
  "#7da3a1",
  "#34675c",
]
edge = "#324851"

@lusingander lusingander merged commit 20a7a97 into master Sep 14, 2024
4 checks passed
@lusingander lusingander deleted the graph-color branch September 14, 2024 06:43
@alerque
Copy link
Contributor

alerque commented Sep 14, 2024

Unrelated to the color scheme: the example graph in this PR looks unnecessarily complex for the info being presented. There are 10 crossing lines for 5 branches when it could be drawn in the same space with 0 crossing lines. Obviously the example is contrived and not all cases will have such a clean possibility, but it does look like the logic is backwards. There are two metrics going on that could be used to cleanup the graph: either the merge point or the date stamp of first commit in the branch. If either of those metrics was used to determine the innermost branch to draw and draw later merge points/later first commit dates farther out in the branch graph the resulting graph would have no overlaps at all and I think it would be much clearer at a glance what was going on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants