Use (x86_64/aarch64)-linux-gnu target platform for native extensions instead of (x86_64/aarch64)-linux #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxirmx
force-pushed
the
maxirmx-issue-105
branch
6 times, most recently
from
ddc9c61 to
ac9f98a
Compare
… added tests for published gem
maxirmx
force-pushed
the
maxirmx-issue-105
branch
4 times, most recently
from
16d35d3 to
1318230
Compare
maxirmx
changed the title
maxirmx
force-pushed
the
maxirmx-issue-105
branch
2 times, most recently
from
bc073e6 to
bffe9c9
Compare
ronaldtse
approved these changes
Dec 16, 2023
|
@maxirmx there’s a single test failure in the Windows test, seems that the tests weren’t even run. Is that something that can be fixed? Thanks! |
maxirmx
force-pushed
the
maxirmx-issue-105
branch
2 times, most recently
from
e289d32 to
b9414c4
Compare
CAMOBAP
reviewed
Dec 16, 2023
CAMOBAP
approved these changes
Dec 16, 2023
maxirmx
force-pushed
the
maxirmx-issue-105
branch
from
7fd3f13 to
de3a6c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rubygems/bundler allow
(x86_64/aarch64)-linux-gnu,(x86_64/aarch64)-linux-musl,(x86_64/aarch64)-linuxtarget platform for native extensions.When
(x86_64/aarch64)-linux-muslis not available Ruby loads(x86_64/aarch64)-linuxon Alpine Linux.Previous versions of CI for this gem optimistically used rake-compiler defaul that created
(x86_64/aarch64)-linuxextension although in most cases it was not compatible with musl environment even with gcompat package installed.So in this PR native extension target is changed to
(x86_64/aarch64)-linux-gnu. On Alpine Linux bundler/Rubygems build bantive extension from sources.There is another issue (#105) that calls for publishing
(x86_64/aarch64)-linux-muslnative extension.