Redux saga monitor as a seperate package #1
Conversation
|
Sorry for the late reply. First thanks for taking the example into a separate package. I plan to start soon working on an UI version of the monitor. Right now I don't have time to review this, but if it works you can publish it if you want. Althouh I'd prefer to be in name different than |
|
|
||
| // Export the snapshot-logging function to run from the browser console or extensions. | ||
| if(IS_BROWSER) { | ||
| window.$$LogSagas = logSaga |
There was a problem hiding this comment.
Please choose a more unique global name, such as __REDUX_SAGA_MONITOR_LOG_SAGAS__. Please see the reasoning here: zalmoxisus/redux-devtools-extension#202
If you're in doubt that the long name would be difficult to run from the browser developer tools console, the console has got a decent auto-complete and command history, so you will only need to enter (read: copy-paste) that once.
| } | ||
|
|
||
| function createSagaMonitor({ verbose = false } = {}) { | ||
| VERBOSE = verbose; |
There was a problem hiding this comment.
This function assumes it is only called once. Please wrap the whole context into it.
Please see https://gist.github.com/sompylasar/5e7157e451f4b7268def9ae1ce01edd4 – I would appreciate much if you used that code instead, and just mentioned me as a contributor. Thanks in advance.
| } | ||
|
|
||
| // Export the snapshot-logging function for arbitrary use by external code. | ||
| export { logSaga, createSagaMonitor }; |
There was a problem hiding this comment.
The logSaga function is context-dependent, it captures the outer context, so it should be in the "saga monitor" that createSagaMonitor creates.
Following the discussion redux-saga/redux-saga#5 a sample logger (or monitor) was created by @yelouafi as an example for redux-saga.
In the latter discussion, moving the monitor to a seperate module with some more tests was discussed.
As today, such package doesn't exists yet, and I wanted to get rid off the
sagaMonitorfrom my project's sources.This monitor is nearly identical to the one available in https://github.com/yelouafi/redux-saga sources, see : https://github.com/yelouafi/redux-saga/blob/master/examples/sagaMonitor/index.js
Notable differences
isPrimitivefunction, this module https://github.com/jonschlinkert/is-primitive was used. (First match on npm, that's it really... 😅)Disclaimer
I really don't want to offend anyone while packaging this. I didn't put much work on this compared to the people engaged in the discussion (@Splact @davej), and tried to reference authors wherever possible (@sompylasar @romseguy).
I would gladly
yieldthe ownership of this to @yelouafi instead of maintaining this myself 😄I'll wait for some review from you guys, and some kind of approval from @yelouafi before merging/publishing anything.