Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ feat: Add methods for node custom certificates #116

Merged
merged 1 commit into from
Feb 20, 2024
Merged

✨ feat: Add methods for node custom certificates #116

merged 1 commit into from
Feb 20, 2024

Conversation

alperencelik
Copy link
Contributor

The PR aims to support custom certificate operations on a node level. Here is the relevant API documentation of Proxmox:

https://pve.proxmox.com/pve-docs/api-viewer/index.html#/nodes/{node}/certificates/custom

Copy link

codecov bot commented Feb 19, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (fdb95a1) 25.95% compared to head (b3539e7) 25.76%.
Report is 3 commits behind head on main.

Files Patch % Lines
nodes.go 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #116      +/-   ##
==========================================
- Coverage   25.95%   25.76%   -0.20%     
==========================================
  Files          15       15              
  Lines        1753     1766      +13     
==========================================
  Hits          455      455              
- Misses       1278     1291      +13     
  Partials       20       20              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luthermonson luthermonson merged commit 76b0664 into luthermonson:main Feb 20, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants