Fix xmdf lock #424
Merged
Fix xmdf lock #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterPetrik
reviewed
Sep 2, 2022
| @@ -66,6 +66,7 @@ class HdfFile | |||
| Create | |||
| }; | |||
| typedef HdfH<H5I_FILE> Handle; | |||
| typedef std::shared_ptr<Handle> SharedHandle; | |||
There was a problem hiding this comment.
do we need new typedef personally for me it is easier to read the code when shared_ptrs are expanded everywhere.
| std::string mPath; | ||
| }; | ||
|
|
||
| typedef std::shared_ptr<HdfFile> HdfFileShared; |
There was a problem hiding this comment.
do we need new typedef personally for me it is easier to read the code when shared_ptrs are expanded everywhere.
mdal/frmts/mdal_hdf5.hpp
Outdated
| HdfGroup( std::shared_ptr<Handle> handle, HdfFile::SharedHandle file ); | ||
|
|
||
| private: | ||
| HdfFile::SharedHandle mFile; //must be the last destroyed |
There was a problem hiding this comment.
I think the commend it misleading, I would remove it. If you want to add comment, I would say do not destroy from this class
There was a problem hiding this comment.
yes, the comment should be "must be declared before std::shared_ptr<Handle> d to be sure it will be the last destroyed"
PeterPetrik
approved these changes
Sep 6, 2022
vcloarec
added a commit
to vcloarec/MDAL
that referenced
this pull request
Oct 11, 2022
vcloarec
added a commit
that referenced
this pull request
Oct 12, 2022
* retrieve exact behavior of FLO2D format before #424 * fix mingw build * fix narrowing conversion * ver++ * typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Xmdf format, when the mesh is closed (for example, removed from QGIS), the files is still locked as it is still open, and user is unable to rename or remove the file until QGIS is closed.
Indeed, the mesh is not closed properly because the file's handle is closed before the dataset's handle are closed, leading to keep the file open.
To close the mesh properly it necessary to close the file's handle once every other Hdf5 handles are closed. To achieve this, a "shared file's handle" is embeded in each HdFGroup and each HdfDataset. This member is declared before the group/dataset handle to be sure the shared handle is destroy once the group/dataset handle is effectively closed.
The destruction of the last shared handle leads to close the file.
To improve the encapsulation around HdfFile, some refactorization are also done.