Hijack e key to prevent nnn.nvim nnn nvim inception

[ggustafsson]

Hello!

When running nnn -p/NnnPicker the "e" (Edit file) key is disabled and that is of course not the case with nnn/NnnExplorer which can make things end up a bit messy if you are not careful. Worst case scenario is that a user ends up pressing "e" by habit while a directory is selected which will start nvim and then nnn.nvim netrw hijack 🤯

See it in action here:
https://asciinema.org/a/500370

I've actually ended up doing this a few times because I use both "e" and return open things in nnn. I tried to hijack it on my end with mappings = {} first but that doesn't work and I figured others might appreciate it too.

Best regards,
Göran Gustafsson

[luukvbaal]

Why do you say it's "of course not the case" for NnnExplorer?

IMO the justification for jarun/nnn@8a1a5db applies to explorer mode as well and we should rather patch nnn than nnn.nvim, no?

[luukvbaal]

I.e.

@@ -7335,7 +7335,7 @@ nochange:
                                copycurname();
                                goto nochange;
                        case SEL_EDIT:
-                               if (!g_state.picker)
+                               if (!(g_state.picker || g_state.fifomode))
                                        spawn(editor, newpath, NULL, NULL, F_CLI);
                                continue;
                        default: /* SEL_LOCK */

[ggustafsson]

Ohh sorry, I didn't realise that there was another mode! That is why I didn't write nnn -F... Sounds like you are absolutely right about this one! 🙂

[ggustafsson]

Thanks 👍