Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to summarise attributes in to_spatial_smooth #120

Closed
luukvdmeer opened this issue Feb 1, 2021 · 2 comments
Closed

Allow to summarise attributes in to_spatial_smooth #120

luukvdmeer opened this issue Feb 1, 2021 · 2 comments
Assignees
Labels
feature 🎁 Request a new feature high priority ⏰ Should be fixed soon to_spatial_smooth All issues related to function `to_spatial_smooth()`

Comments

@luukvdmeer
Copy link
Owner

Is your feature request related to a problem? Please describe.
In the new release of sfnetworks, the to_spatial_contracted morpher (which merges nodes) and the to_spatial_simple morpher (which merges edges) have the argument summarise_attributes which allows you to specify on a per-attribute basis how the attribute values of a new, merged feature should be inferred from the original features. There is one more morpher currently that merges features: to_spatial_smooth merges edges after removing pseudo nodes. It would be nice when the summarise_attributes argument is also implemented there.

However: the implementation of this argument in the contraction and simplification was quite easy, since igraph provides it and it only had to be forwarded to igraph::contract and igraph::simplify respectively. The smooth functionality however is self-implemented and does not use existing igraph functions (as far as I know igraph does not have a function for removing pseudo nodes). This will make it more complicated to add the argument.

Describe the solution you'd like
A summarise_attributes argument in to_spatial_smooth.

@luukvdmeer luukvdmeer added the feature 🎁 Request a new feature label Feb 1, 2021
@luukvdmeer
Copy link
Owner Author

See also #179 and #181 having the same feature request.

@luukvdmeer luukvdmeer self-assigned this Nov 26, 2021
@luukvdmeer luukvdmeer added the high priority ⏰ Should be fixed soon label Nov 26, 2021
@luukvdmeer luukvdmeer added the to_spatial_smooth All issues related to function `to_spatial_smooth()` label Nov 26, 2021
luukvdmeer added a commit that referenced this issue Aug 2, 2022
luukvdmeer added a commit that referenced this issue Aug 2, 2022
@luukvdmeer
Copy link
Owner Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature 🎁 Request a new feature high priority ⏰ Should be fixed soon to_spatial_smooth All issues related to function `to_spatial_smooth()`
Projects
None yet
Development

No branches or pull requests

1 participant