Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

try safe handle external handle #733

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

try safe handle external handle #733

wants to merge 2 commits into from
+285 −2

Conversation

zhaozg
Copy link
Member

@zhaozg zhaozg commented Nov 9, 2024

No description provided.

@zhaozg zhaozg mentioned this pull request Nov 9, 2024
Draft
@zhaozg
Copy link
Member Author

zhaozg commented Nov 9, 2024

A random ci fail: https://github.com/zhaozg/luv/actions/runs/11754015398/job/32747531427

rdw-software
rdw-software reviewed Nov 12, 2024
View reviewed changes
Copy link
Contributor

@rdw-software rdw-software left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't measure performance as it's unlikely to matter, but the loop can be shared without crashing when using the patch :)

src/loop.c Outdated Show resolved Hide resolved
src/loop.c Outdated Show resolved Hide resolved
src/loop.c Outdated Show resolved Hide resolved
src/handle.c Outdated Show resolved Hide resolved
src/handle.c Outdated Show resolved Hide resolved
src/luv.h Outdated Show resolved Hide resolved
src/luv.h Outdated Show resolved Hide resolved
@zhaozg
Copy link
Member Author

zhaozg commented Nov 12, 2024

Didn't measure performance as it's unlikely to matter, but the loop can be shared without crashing when using the patch :)

Thanks for your check, I'll update when I have free time, in this week.

@zhaozg zhaozg changed the title try safe handle external handle [RDY]try safe handle external handle Nov 13, 2024
@zhaozg zhaozg changed the title [RDY]try safe handle external handle try safe handle external handle Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdw-software rdw-software rdw-software left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhaozg @rdw-software