Skip to content

Commit

Permalink
[bugfix](inverted index)temporary disable skip read column data if it…
Browse files Browse the repository at this point in the history
… match inverted index (apache#18065)

The optimization for skip reading column data if it match inverted index and only used in WHERE clause may get wrong result for complex SQL.

This PR temporary disable the optimization and later PRs will resolve the problem fundamentality.
  • Loading branch information
xiaokang authored Mar 27, 2023
1 parent dc7b201 commit d1f34a3
Showing 1 changed file with 1 addition and 7 deletions.
8 changes: 1 addition & 7 deletions be/src/olap/rowset/segment_v2/segment_iterator.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -852,13 +852,7 @@ Status SegmentIterator::_apply_inverted_index_on_block_column_predicate(
}

bool SegmentIterator::_need_read_data(ColumnId cid) {
int32_t unique_id = _schema.unique_id(cid);
if (_need_read_data_indices.count(unique_id) > 0 && !_need_read_data_indices[unique_id] &&
_output_columns.count(unique_id) < 1) {
VLOG_DEBUG << "SegmentIterator no need read data for column: "
<< _opts.tablet_schema->column_by_uid(unique_id).name();
return false;
}
// TODO(xk) impl right logic
return true;
}

Expand Down

0 comments on commit d1f34a3

Please sign in to comment.