Update plot_config to plotting_style and documentation #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dorisjlee
reviewed
Jan 22, 2021
doc/source/guide/style.rst
Outdated
| .. code-block:: python | ||
|
|
||
| lux.config.plotting_backend = "matplotlib" # or 'matplotlib_code' | ||
| lux.config.plotting_backend = "matplotlib" # or 'matplotlib_code' | ||
|
|
||
| def add_title(fig, ax): |
There was a problem hiding this comment.
Can we show the same example as above of changing color and adding title. It might be good to demonstrate how we can change settings for fig and ax parameter and when we should use each. Also would we be able to set something like plt.rcParam? A few examples outlining the possible style changes here with links to matplotlib docs would be helpful here.
|
Thanks @caitlynachen! Let's add a test case when |
jerrysong1324
approved these changes
Jan 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the 'plot_config' parameter in the lux.config class to 'plotting_style' to be in alignment with other plotting parameter, 'plotting_backend'.
Updated the documentation accordingly