Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conda setup #264

Merged
merged 41 commits into from
Feb 16, 2021
Merged

Conda setup #264

merged 41 commits into from
Feb 16, 2021

Conversation

cjachekang
Copy link
Contributor

@cjachekang cjachekang commented Feb 14, 2021

Finished all of the work on the conda-forge side - merging in documentation for how to install via Conda and the yaml files so that we can update the recipe in the future.

In the future, in order to update the recipes, you can follow the directions here: https://conda-forge.org/#update_recipe
We should only have to update the recipes for new dependencies/updating version numbers.

You can install via conda install -c conda-forge lux-api

@@ -0,0 +1,43 @@
{% set name = "lux-api" %}
{% set version = "0.2.2" %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to read this number directly from _version.py so that we wouldn't have to update the recipe every time there is a new release? A similar thing that reads from Github tags is done here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can try this approach out, I have already uploaded 0.2.2 to conda-forge so I will try it for the new release

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok that sounds good!

@@ -0,0 +1,48 @@
{% set name = "lux-widget" %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we put this file inside the lux-widget repo?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I can do that

@@ -0,0 +1,48 @@
{% set name = "lux-widget" %}
{% set version = "0.1.3" %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similiarly, this way the version can be read in from _version.py or package.json

change conda install instruction into one-liner
@dorisjlee
Copy link
Member

Thanks @cjachekang! I tested this on Docker with Anaconda and it works perfectly. I made minor adjustment to make the README install instruction a one-liner and left some comments. Could you add some description of when and how to update the conda recipes, including links and which files to modify inside CONTRIBUTING.md?

@dorisjlee dorisjlee merged commit 704370b into lux-org:master Feb 16, 2021
@dorisjlee
Copy link
Member

Thanks @cjachekang !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants