-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move widget display to Out[...]
#308
Conversation
Codecov Report
@@ Coverage Diff @@
## master #308 +/- ##
==========================================
- Coverage 80.87% 80.02% -0.85%
==========================================
Files 50 50
Lines 3618 3615 -3
==========================================
- Hits 2926 2893 -33
- Misses 692 722 +30
Continue to review full report at Codecov.
|
Hi @westernguy2, The improved output looks much more Pandas-consistent than what we had before! Could we use the @cjachekang, @westernguy2: Were you able to test this on Jupyter Lab? I tried this on lab but the widget doesn't seem to be displaying. It is possible that there is something wrong with my lab setup. |
This looks great, thanks @westernguy2! |
Overview
The widget display used to be displayed before Out[...], which is not in accordance to what Pandas usually does. This PR moves the widget to Out[...] in IPython notebooks. This PR addresses both #56 and #60
Changes
I replaced
_repr_html_
with_ipython_display_
in bothframe.py
andvis.py
. I then removed__repr__
fromframe.py
so that it uses the Pandas default__repr__
when the widget isn't displayed. I added a test to ensure this is the case.Example Output
Below is an example of the widget showing up in Out[...]. Notice that Out[...] doesn't show up below the widget, which means the widget is actually in Out[...]