-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor LuxGroupBy using multiple inheritance #309
Conversation
…o pandas-tests-staging
Codecov Report
@@ Coverage Diff @@
## master #309 +/- ##
==========================================
- Coverage 81.08% 80.97% -0.11%
==========================================
Files 50 50
Lines 3569 3596 +27
==========================================
+ Hits 2894 2912 +18
- Misses 675 684 +9
Continue to review full report at Codecov.
|
Thanks @westernguy2! If I understand this correctly, we don't currently support series groupby (only |
The I can add a test similar to the ones related to |
Also, yes, this PR also allows metadata propagation through |
That's great, I was thinking that this new |
@dorisjlee Added a test for |
Thanks @westernguy2, this looks good! Merging this in now! |
Overview
Refactored
LuxGroupBy
to look similar to how Pandas structures GroupBy objects, separating them inLuxDataFrameGroupBy
andLuxSeriesGroupBy
. This will allow us to extend methods for specific types of GroupBy objects.Also fixed a minor bug for testing purposes.
Changes
Used multiple inheritance to ensure each
LuxGroupBy
child class also inherits the corresponding Pandas version. They all have a parent class ofLuxGroupBy
. Also fixed a bug where the Pandas tests were not using Lux since it was using a different type of Series object. This was added to__init__.py
to ensure it points toLuxSeries
.Example Output
No example output for this PR.