Update LuxSQLTable __len__() and metadata computation"" #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b5998c7.
thyneb19
changed the title
Updated _is_datetime_number() in the PandasExecutor to use the is_integer_dtype() function to check if a series is of int dtype. Cleaned up SQLExecutor checks in frame.py
dorisjlee
approved these changes
Apr 7, 2021
|
This looks great, thanks @thyneb19 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Added len() function capability to the LuxSQLTable and updated metadata handling.
Changes
Made changes to the LuxSQLTable to enable
len(sql_tbl)functionality. Updated references to thesql_tbl._lengthparameter throughout the code to be replaced bylen(sql_tbl). Making these changes also required updating the metadata calculation process for the LuxSQLTable.During the initial setup of the LuxSQLTable, it needs to have the same
len()functionality as the LuxDataFrame. Added a boolean parameter to keep track of which part of setup a LuxSQLTable is in, and this informslen()to either returnsql_tbl._lengthor the parent class'len().