Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Vis export API name: to_matplotlib, to_altair, to_vegalite #359

Merged
merged 3 commits into from
Apr 15, 2021

Conversation

caitlynachen
Copy link
Contributor

@caitlynachen caitlynachen commented Apr 14, 2021

Overview

Adjust user-facing to_matplotlib_code() Vis function to to_matplotlib() to simplify commands.

Changes

  • Created private method to generate charts on plotting backend.
  • Changed to_matplotlib_code() Vis function to to_matplotlib(), so users can access a simplified command
  • Adjusted documentation to reflect changes
  • Changed to_Altair and to_VegaLite to lowercase to_altair and to_vegalite to make naming consistent.

Example Output

Screen Shot 2021-04-14 at 10 12 52 AM

@caitlynachen caitlynachen requested review from westernguy2 and dorisjlee and removed request for westernguy2 April 14, 2021 17:42
@codecov
Copy link

codecov bot commented Apr 14, 2021

Codecov Report

Merging #359 (2847611) into master (939799f) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

❗ Current head 2847611 differs from pull request most recent head 5340b11. Consider uploading reports for the commit 5340b11 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #359      +/-   ##
==========================================
- Coverage   84.29%   84.21%   -0.08%     
==========================================
  Files          51       51              
  Lines        3884     3884              
==========================================
- Hits         3274     3271       -3     
- Misses        610      613       +3     
Impacted Files Coverage Δ
lux/_config/config.py 86.25% <100.00%> (ø)
lux/vis/Vis.py 75.44% <100.00%> (+0.59%) ⬆️
lux/vislib/matplotlib/MatplotlibRenderer.py 87.30% <100.00%> (ø)
lux/vislib/altair/Heatmap.py 93.10% <0.00%> (-3.45%) ⬇️
lux/vislib/altair/ScatterChart.py 93.93% <0.00%> (-3.04%) ⬇️
lux/vislib/matplotlib/Heatmap.py 96.66% <0.00%> (-1.67%) ⬇️
lux/vislib/matplotlib/ScatterChart.py 75.29% <0.00%> (-1.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 939799f...5340b11. Read the comment docs.

lux/core/frame.py Outdated Show resolved Hide resolved
@dorisjlee
Copy link
Member

Thanks @caitlynachen, this looks great! I made some changes to the code and docs. Could you look through my changes and test the code to make sure that my changes didn't break anything? Let's also make sure that the lux-binder tutorial is updated according to our changes to 3-export.rst in a separate PR to lux-binder.

@dorisjlee dorisjlee changed the title Change to_matplotlib() option to display code by default Change Vis export API name: to_matplotlib, to_altair, to_vegalite Apr 15, 2021
@dorisjlee dorisjlee merged commit 315e385 into lux-org:master Apr 15, 2021
@dorisjlee dorisjlee mentioned this pull request Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants