Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing to Choropleth width and int type error #395

Merged
merged 3 commits into from
Jun 30, 2021

Conversation

dorisjlee
Copy link
Member

@dorisjlee dorisjlee commented Jun 30, 2021

Overview

@cjachekang reported an issue with integer type geographic columns, as shown in the communities dataset.
image (15)
This PR fixes the issue and displays the integer state columns based on their FIPS directly.
In addition, this PR also increases the width of choropleth charts so that the visualizations don't appear to be too squished horizontally.

@codecov
Copy link

codecov bot commented Jun 30, 2021

Codecov Report

Merging #395 (7fc298e) into master (2b6e162) will increase coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #395      +/-   ##
==========================================
+ Coverage   84.93%   85.02%   +0.08%     
==========================================
  Files          52       52              
  Lines        4030     4033       +3     
==========================================
+ Hits         3423     3429       +6     
+ Misses        607      604       -3     
Impacted Files Coverage Δ
lux/vislib/altair/AltairChart.py 91.80% <100.00%> (+0.27%) ⬆️
lux/vislib/altair/Choropleth.py 92.95% <100.00%> (+8.67%) ⬆️
lux/vislib/altair/Heatmap.py 93.10% <0.00%> (-3.45%) ⬇️
lux/vislib/matplotlib/Heatmap.py 96.66% <0.00%> (-1.67%) ⬇️
lux/vislib/matplotlib/ScatterChart.py 75.58% <0.00%> (-1.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b6e162...7fc298e. Read the comment docs.

@dorisjlee dorisjlee merged commit 17dd0ee into lux-org:master Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant