Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added timestamp import to matplotlib linecharts (#396) #397

Merged
merged 3 commits into from
Jul 5, 2021

Conversation

dorisjlee
Copy link
Member

@dorisjlee dorisjlee commented Jul 5, 2021

closes #396

also temporary fix for #398

@codecov
Copy link

codecov bot commented Jul 5, 2021

Codecov Report

Merging #397 (bbdb803) into master (17dd0ee) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #397      +/-   ##
==========================================
- Coverage   85.09%   85.05%   -0.05%     
==========================================
  Files          52       52              
  Lines        4033     4034       +1     
==========================================
- Hits         3432     3431       -1     
- Misses        601      603       +2     
Impacted Files Coverage Δ
lux/vislib/matplotlib/LineChart.py 88.88% <100.00%> (+0.15%) ⬆️
lux/vislib/altair/ScatterChart.py 93.93% <0.00%> (-3.04%) ⬇️
lux/vislib/matplotlib/ScatterChart.py 75.58% <0.00%> (-1.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17dd0ee...bbdb803. Read the comment docs.

@dorisjlee dorisjlee merged commit 0d934dd into lux-org:master Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Matplotlib code throwing error for temporal charts
1 participant