Replace infs with nans to avoid crash when creating a heatmap #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #442 +/- ##
==========================================
+ Coverage 65.55% 65.62% +0.06%
==========================================
Files 55 55
Lines 4419 4422 +3
==========================================
+ Hits 2897 2902 +5
+ Misses 1522 1520 -2
Continue to review full report at Codecov.
|
Signed-off-by: Cristian Garcia <cgarcia.e88@gmail.com>
cgarciae
force-pushed
the
fix-infs-in-heatmap
branch
from
7df184e
to
ac88f82
Compare
dorisjlee
reviewed
Jan 8, 2022
lux/executor/PandasExecutor.py
Outdated
| @@ -11,6 +11,7 @@ | |||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | |||
| # See the License for the specific language governing permissions and | |||
| # limitations under the License. | |||
| # fmt: off | |||
There was a problem hiding this comment.
Will remove it, vscode was formatting this file that is supposed to be ignored.
|
Thanks @cgarciae! I left a few minor suggestions, otherwise, this looks good to merge soon! |
Co-authored-by: Doris Lee <dorisjunglinlee@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Cristian Garcia cgarcia.e88@gmail.com
Overview
Fixes #440 by replacing
infs withnans.Changes
Uses
inside
PandasExecutor.pyon several places to removeinfs.