Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX-#447: Add debug information if luxwidget extension is not enabled. #457

Merged
merged 2 commits into from
Feb 14, 2022

Conversation

dorisjlee
Copy link
Member

@dorisjlee dorisjlee commented Feb 13, 2022

Overview

Per #447, add some debug information (i.e. a warning) in case luxwidget is not installed/enabled.

Signed-off-by: Doris Lee <dorisjunglinlee@gmail.com>
…d added

suggested commands

Signed-off-by: Doris Lee <dorisjunglinlee@gmail.com>
@codecov
Copy link

codecov bot commented Feb 13, 2022

Codecov Report

Merging #457 (77109c4) into master (a402c49) will decrease coverage by 0.82%.
The diff coverage is 19.31%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #457      +/-   ##
==========================================
- Coverage   65.28%   64.46%   -0.83%     
==========================================
  Files          56       56              
  Lines        4474     4559      +85     
==========================================
+ Hits         2921     2939      +18     
- Misses       1553     1620      +67     
Impacted Files Coverage Δ
lux/utils/debug_utils.py 19.41% <17.44%> (-6.90%) ⬇️
lux/__init__.py 100.00% <100.00%> (ø)
lux/vislib/altair/ScatterChart.py 96.96% <0.00%> (+3.03%) ⬆️
lux/vislib/altair/Heatmap.py 96.55% <0.00%> (+3.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a402c49...77109c4. Read the comment docs.

@dorisjlee dorisjlee merged commit 58c1be5 into lux-org:master Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant