Refactor ImageManip node #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the calculated parameters for the warp filter
…r the case when the center of the rectangle crop is very close to the image border
…actor 2. Update FW - Merge remote-tracking branch 'origin/develop' into image_manip_refactor - [BUG FIXED] YUV420/NV12 -> RGB conversion produces artefacts(for classification scenario) - [BUG FIXED] large resize unsupported on YUV420/NV12 format(for classification scenario) - [BUG FIXED] CMX memory corruption when output format is YUV420/NV12 - [FEATURE ADDED] Adding support for 4K input/output resolution
[API maintained]
[setKeepAspectRatio]
- resize with keeping aspect ratio + crop the input field of view to match the output aspect ratio
- using the "setKeepAspectRatio" API in conjunction with the "setResizeThumbnail" API, the "setKeepAspectRatio" API will not have any effect because the "setResizeThumbnail" API has priority
- keepAspectRatio config is True by default
[bugs fixed]
[artifacts/memory coruption]
Properly extract the chroma rect
Properly compute the luma/chroma cached memory size
Input interleaved -> planar conversion + rect rotation
[hang]
input rectangle outside frame
alex-luxonis
force-pushed
the
image_manip_refactor
branch
from
0b23c73 to
75d9906
Compare
|
Woohoo!!! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features added:
Note: Planar formats are faster to process (eg. interleaved RGB/BGR or NV12 are more taxing on memory transfers because of how the internal conversion to planar gets made). Converting to interleaved formats is without any penalties.
Known issues(related to the current version, not to the mainline one):
setCropRotatedRectandsetResizeThumbnailAPIs are used in the same config,setResizeThumbnailwill resize without keeping the aspect ratio; issue related: Processing failed, potentially unsupported config depthai-python#529 (WIP)- no ImageManip issues present on the custom demo provided, just wrong pipeline configuration
ImageManipnode combining rotation and resizing depthai#602New issues discovered at debug:
ToDo