Fix precedence of nn model path ros_param > nn_config.yaml #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MRo47
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Author: Myron Rodrigues
Issue
Issue link (if present):
Issue description: Hard coded path in nn_config takes precedence over ros param. Depending on where ROS2 install shared directory lives this path can change, ros param should be the correct way to set this, by fetching the shared directory?
Related PRs
Changes
ROS distro:
List of changes:
Testing
Hardware used: OAK-D wide pro
Depthai library version:
2.28.0Depthai ros version:
cf5d2aaee9117298ea1632c98ffd36a5d7d535ac