refactor effect chain #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
|
Code Climate has analyzed commit 80315df and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 96.4% (50% is the threshold). This pull request will bring the total coverage in the repository to 41.9% (0.2% change). View more on Code Climate. |
slowfox089
pushed a commit
to slowfox089/luya-module-admin
that referenced
this pull request
Dec 10, 2020
* refactor effect chain * add changelog, upgrade and phpdoc * add tests * crop effect * apply more effects to chain * fix multiple request tests * elseif instead of switch * add exception tests * add text effect test which should fail * generic exception * update docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this closes #467